Messages in this thread | | | From | NeilBrown <> | Date | Wed, 27 Apr 2016 15:43:11 +1000 | Subject | Re: [PATCH 02/19] radix-tree: Miscellaneous fixes |
| |
On Fri, Apr 15 2016, Matthew Wilcox wrote:
> Typos, whitespace, grammar, line length, using the correct types, etc. > > Signed-off-by: Matthew Wilcox <willy@linux.intel.com> > Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > -static inline void root_tag_clear(struct radix_tree_root *root, unsigned int tag) > +static inline void root_tag_clear(struct radix_tree_root *root, unsigned tag)
Changing "unsigned int" to "unsigned" - Bold.
> { > root->gfp_mask &= (__force gfp_t)~(1 << (tag + __GFP_BITS_SHIFT)); > } > @@ -159,7 +159,7 @@ static inline void root_tag_clear_all(struct radix_tree_root *root) > > static inline int root_tag_get(struct radix_tree_root *root, unsigned int tag)
Not doing it uniformly - Priceless.
NeilBrown [unhandled content-type:application/pgp-signature] | |