Messages in this thread | | | Subject | Re: [RFC][PATCH 22/31] locking,tile: Implement atomic{,64}_fetch_{add,sub,and,or,xor}() | From | Chris Metcalf <> | Date | Tue, 26 Apr 2016 11:32:55 -0400 |
| |
On 4/26/2016 11:28 AM, Peter Zijlstra wrote: > On Mon, Apr 25, 2016 at 04:54:34PM -0400, Chris Metcalf wrote: >> Otherwise, though just based on code inspection so far: >> >> Acked-by: Chris Metcalf <cmetcalf@mellanox.com> [for tile] > Thanks! > > Just to verify; the new fetch-op thingies _do_ indeed need the extra > smp_mb() as per my patch, because there is no trailing instruction > depending on the completion of the load?
Exactly. I should have said so explicitly :-)
-- Chris Metcalf, Mellanox Technologies http://www.mellanox.com
| |