Messages in this thread | | | Date | Tue, 26 Apr 2016 14:37:07 +0200 | From | Jan Kara <> | Subject | Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() |
| |
On Tue 26-04-16 14:31:58, Nicolas Dichtel wrote: > Le 26/04/2016 13:08, Jan Kara a écrit : > > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote: > >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > > > > OK, so I somewhat miss a description of what will this do to the netlink > > message so that I can judge whether the change is fine for the userspace > > counterpart parsing these messages. AFAIU this changes the message format > > by adding a QUOTA_NL_A_PAD field before each 64-bit field which needs an > > alignment, am I guessing right? Thus when the userspace counterpart uses > > genlmsg_parse() it should just silently ignore these attributes if I read > > the documentation right. Did I understand this correctly? > Yes, that's it.
OK, then feel free to add:
Acked-by: Jan Kara <jack@suse.cz>
to the quota patch.
Honza
-- Jan Kara <jack@suse.com> SUSE Labs, CR
| |