Messages in this thread | | | Date | Mon, 25 Apr 2016 14:45:33 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH 07/10] cpufreq: dt: Identify cpu-sharing for platforms without operating-points-v2 |
| |
On 04/25, Viresh Kumar wrote: > On 22-04-16, 15:27, Stephen Boyd wrote: > > On 04/21, Viresh Kumar wrote: > > > @@ -167,14 +167,16 @@ static int cpufreq_init(struct cpufreq_policy *policy) > > > /* Get OPP-sharing information from "operating-points-v2" bindings */ > > > ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, policy->cpus); [..] > > > + if (dev_pm_opp_get_sharing_cpus(cpu_dev, policy->cpus)) > > > + fallback = true; > > > > I'm sort of lost, we make the same call twice here. Why would the > > return value change between the first time and the second? > > Two different APIs, which look similar :) > > The first one tries to find the sharing-cpus relation from DT, the > other one is for v1 bindings and finds it due to platform code > dev_pm_opp_set_sharing_cpus() call.
Ah thanks. My eyes glossed over the "of" part. Sounds fine.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |