Messages in this thread | | | Date | Mon, 25 Apr 2016 10:47:32 -0700 | From | Darren Hart <> | Subject | Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set |
| |
On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote: > Properly return rv back to the caller in the case of an error in > parse_arg. In the process remove a unused variable 'out'. > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
1 and 2 queued for 4.7.
> --- > drivers/platform/x86/asus-laptop.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > index d86d42e..9a69734 100644 > --- a/drivers/platform/x86/asus-laptop.c > +++ b/drivers/platform/x86/asus-laptop.c > @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus, > const char *method) > { > int rv, value; > - int out = 0; > > rv = parse_arg(buf, count, &value); > - if (rv > 0) > - out = value ? 1 : 0; > + if (rv <= 0) > + return rv; > > if (write_acpi_int(asus->handle, method, value)) > return -ENODEV; > -- > 2.8.0 > >
-- Darren Hart Intel Open Source Technology Center
| |