lkml.org 
[lkml]   [2016]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCHv3 1/5] efi/runtime-wrappers: detect FW irq flag corruption
    From
    On 25 April 2016 at 16:15, Matt Fleming <matt@codeblueprint.co.uk> wrote:
    > On Mon, 25 Apr, at 03:12:01PM, Robin Murphy wrote:
    >> >+static void efi_call_virt_check_flags(unsigned long flags, const char *call)
    >> >+{
    >> >+ unsigned long cur_flags;
    >> >+ bool mismatch;
    >> >+
    >> >+ local_save_flags(cur_flags);
    >> >+
    >> >+ mismatch = !!((cur_flags ^ flags) & ARCH_EFI_IRQ_FLAGS_MASK);
    >>
    >> nit: the assignment itself is already a conversion to bool, so the
    >> excitement is redundant here.
    >
    > This was intentional. I asked Mark to make this change so that it's
    > explicit for the developer that we're performing the type conversion.

    But replacing an implicit boolean cast with an explicit one makes
    little sense, no? Don't we simply want '!= 0' here if you need a
    boolean expression?

    \
     
     \ /
      Last update: 2016-04-25 16:41    [W:3.426 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site