Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH] net: dsa: mv88e6xxx: fix uninitialized error return | Date | Mon, 25 Apr 2016 21:24:34 -0400 |
| |
Hi Colin,
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com> > > The error return err is not initialized and there is a possibility > that err is not assigned causing mv88e6xxx_port_bridge_join to > return a garbage error return status. Fix this by initializing err > to 0. > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Even though that cannot happen, the fix doesn't hurt. Adding Geert in the loop who submitted an RFC for this first:
https://lkml.org/lkml/2016/4/25/95
Thanks,
Vivien
| |