Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Sun, 24 Apr 2016 22:03:49 +0100 | Subject | Re: [PATCH 2/2] [media] tvp5150: propagate I2C write error in .s_register callback |
| |
On Fri, Apr 15, 2016 at 2:00 AM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The tvp5150_write() function can fail so don't return 0 unconditionally > in tvp5150_s_register() but propagate what's returned by tvp5150_write(). > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers, --Prabhakar Lad
> --- > > drivers/media/i2c/tvp5150.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index 4a2e851b6a3b..7be456d1b071 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -1161,8 +1161,7 @@ static int tvp5150_g_register(struct v4l2_subdev *sd, struct v4l2_dbg_register * > > static int tvp5150_s_register(struct v4l2_subdev *sd, const struct v4l2_dbg_register *reg) > { > - tvp5150_write(sd, reg->reg & 0xff, reg->val & 0xff); > - return 0; > + return tvp5150_write(sd, reg->reg & 0xff, reg->val & 0xff); > } > #endif > > -- > 2.5.5 >
| |