lkml.org 
[lkml]   [2016]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] lib: make sg_pool tristate instead of bool
From
On Sat, Apr 23, 2016 at 7:44 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The recently added Kconfig controlling compilation of this code is:
>
> lib/Kconfig:config SG_POOL
> lib/Kconfig: def_bool n
>
> ...meaning that it currently is not being built as a module by anyone,
> and that tripped my audit looking for modular code that is essentially
> orphaned (i.e. module_exit, and .remove fcns in non-modular drivers.)
>
> In the following discussion, Ming Lin indicated that the original
> intention was to have it tristate, so here we convert it accordingly.
>
> Also fix up a couple spelling issues that appear in the surrounding
> patch context.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lin <ming.l@ssi.samsung.com>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [v2: drop modular code removal patch in favour of supporting a modular
> build via a one line Kconfig patch as per Ming's comments. Build tested
> for allmodconfig on ARM and x86-64 on linux-next. ]
>
> lib/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index e04f168f8f42..8de5868804b5 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -528,13 +528,13 @@ config SG_SPLIT
> help
> Provides a helper to split scatterlists into chunks, each chunk being
> a scatterlist. This should be selected by a driver or an API which
> - whishes to split a scatterlist amongst multiple DMA channels.
> + wishes to split a scatterlist amongst multiple DMA channels.
>
> config SG_POOL
> - def_bool n
> + def_tristate n
> help
> Provides a helper to allocate chained scatterlists. This should be
> - selected by a driver or an API which whishes to allocate chained
> + selected by a driver or an API which wishes to allocate chained
> scatterlist.
>
> #

Looks good.

Acked-by: Ming Lin <ming.l@ssi.samsung.com>

Thanks.

\
 
 \ /
  Last update: 2016-04-24 06:01    [W:0.091 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site