Messages in this thread | | | Subject | Re: [patch] iio: light: apds9960: silence uninitialized variable warning | From | Jonathan Cameron <> | Date | Sat, 23 Apr 2016 22:18:38 +0100 |
| |
On 22/04/16 11:04, Dan Carpenter wrote: > It causes a static checker warning if we use "buf" on the failure path > so move that inside the if statement. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to the togreg branch of iio.git,
Thanks,
Jonathan > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c > index a6af56a..fbdd172 100644 > --- a/drivers/iio/light/apds9960.c > +++ b/drivers/iio/light/apds9960.c > @@ -491,9 +491,10 @@ static int apds9960_read_raw(struct iio_dev *indio_dev, > case IIO_INTENSITY: > ret = regmap_bulk_read(data->regmap, chan->address, > &buf, 2); > - if (!ret) > + if (!ret) { > ret = IIO_VAL_INT; > - *val = le16_to_cpu(buf); > + *val = le16_to_cpu(buf); > + } > break; > default: > ret = -EINVAL; >
| |