Messages in this thread | | | Date | Fri, 22 Apr 2016 21:00:40 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH] irqdomain: fix compare_const_fl.cocci warnings |
| |
On Fri, 22 Apr 2016, Jon Hunter wrote:
> > On 20/04/16 17:49, Julia Lawall wrote: > > Move constants to the right of binary operators. > > > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > > --- > > > > Not a big deal, but the transformed code looks better to me. > > > > irqdomain.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/kernel/irq/irqdomain.c > > +++ b/kernel/irq/irqdomain.c > > @@ -618,7 +618,7 @@ unsigned int irq_create_fwspec_mapping(s > > * If the trigger type has not been set yet, then set > > * it now and return the interrupt number. > > */ > > - if (IRQ_TYPE_NONE == irq_get_trigger_type(virq)) { > > + if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) { > > irq_set_irq_type(virq, type); > > return virq; > > } > > What branch is this from? Looks very familiar and related to some > changes I have been working on, but in my latest version I already have > this as shown above [0].
Sorry, I didn't save that information. If it's done, it's done. Sorry for the noise.
julia
> Cheers > Jon > > [0] http://marc.info/?l=linux-tegra&m=146115064322071&w=2 > >
| |