lkml.org 
[lkml]   [2016]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff
From
Date
Hello.

On 04/21/2016 09:15 PM, Andy Shevchenko wrote:

> The original code states:
>
> Make sure a LLI block is not created that will span 8K max FIS
> boundary. If the block spans such a FIS boundary, there is a chance
> that a DMA burst will cross that boundary -- this results in an error
> in the host controller.
>
> Since we have switched to generic DMAengine API we satisfy above by setting
> dma_boundary value to 0x1fff.
>
> Suggested-by: Mans Rullgard <mans@mansr.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ata/sata_dwc_460ex.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 7f95389..aee8873 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -1151,7 +1151,13 @@ static struct scsi_host_template sata_dwc_sht = {
> */
> .sg_tablesize = LIBATA_MAX_PRD,
> /* .can_queue = ATA_MAX_QUEUE, */
> - .dma_boundary = ATA_DMA_BOUNDARY,
> + /*
> + * Make sure a LLI block is not created that will span 8K max FIS
> + * boundary. If the block spans such a FIS boundary, there is a chance
> + * that a DMA burst will cross that boundary -- this results in an
> + * error in the host controller.
> + */
> + .dma_boundary = 0x1fff /* ATA_DMA_BOUNDARY */,

Not ~0x1fff?

[...]

MBR, Sergei

\
 
 \ /
  Last update: 2016-04-22 15:21    [W:0.131 / U:1.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site