Messages in this thread Patch in this message | | | From | changbin.du@intel ... | Subject | [PATCH 2/7] debugobjects: correct the usage of fixup call results | Date | Fri, 22 Apr 2016 16:07:43 +0800 |
| |
From: "Du, Changbin" <changbin.du@intel.com>
If debug_object_fixup() return non-zero when problem has been fixed. But the code got it backwards, it taks 0 as fixup successfully. So fix it.
Signed-off-by: Du, Changbin <changbin.du@intel.com> --- lib/debugobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/debugobjects.c b/lib/debugobjects.c index a9cee16..2f07c8c 100644 --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -415,7 +415,7 @@ int debug_object_activate(void *addr, struct debug_obj_descr *descr) state = obj->state; raw_spin_unlock_irqrestore(&db->lock, flags); ret = debug_object_fixup(descr->fixup_activate, addr, state); - return ret ? -EINVAL : 0; + return ret ? 0 : -EINVAL; case ODEBUG_STATE_DESTROYED: debug_print_object(obj, "activate"); -- 2.7.4
| |