Messages in this thread | | | Date | Fri, 22 Apr 2016 00:27:14 +0300 | Subject | Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications | From | Andy Shevchenko <> |
| |
On Wed, Apr 20, 2016 at 1:39 AM, Octavian Purdila <octavian.purdila@intel.com> wrote: > This patch adds supports for I2C device enumeration and removal via > ACPI reconfiguration notifications that are send as a result of an > ACPI table load or unload operation.
> > acpi_dev_free_resource_list(&resource_list); > > + strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type));
strscpy() ?
> +static int acpi_i2c_match_adapter(struct device *dev, void *data) > +{ > + struct i2c_adapter *adapter = i2c_verify_adapter(dev); > + > + if (!adapter) > + return 0; > +
> + return ACPI_HANDLE(dev) == (acpi_handle)data;
What is suppose to return? Hidden bool to integer conversion is not best option I suppose.
> +} > + > +static int acpi_i2c_match_device(struct device *dev, void *data) > +{ > + return ACPI_COMPANION(dev) == data;
Ditto.
> +}
-- With Best Regards, Andy Shevchenko
| |