Messages in this thread | | | Subject | Re: [PATCH 5/6] fs: define a string representation of the kernel_read_file_id enumeration | From | Andy Shevchenko <> | Date | Thu, 21 Apr 2016 20:13:43 +0300 |
| |
On Thu, 2016-04-21 at 09:47 -0700, Kees Cook wrote: > On Thu, Apr 21, 2016 at 6:26 AM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Wed, 2016-04-20 at 15:46 -0700, Kees Cook wrote: > > > > > > From: Mimi Zohar <zohar@linux.vnet.ibm.com> > > > > > > A string representation of the kernel_read_file_id enumeration is > > > needed for displaying messages (eg. pr_info, auditing) that can be > > > used by multiple LSMs and the integrity subsystem. To simplify > > > keeping the list of strings up to date with the enumeration, this > > > patch defines two new preprocessing macros named __fid_enumify and > > > __fid_stringify to create the enumeration and an array of strings. > > > kernel_read_file_id_str() returns a string based on the > > > enumeration.
> > I got this > > > > In file included from /home/andy/prj/linux- > > topic/include/linux/seq_file.h:10:0, > > from /home/andy/prj/linux- > > topic/include/linux/pinctrl/consumer.h:17, > > from /home/andy/prj/linux- > > topic/include/linux/pinctrl/devinfo.h:21, > > from /home/andy/prj/linux- > > topic/include/linux/device.h:24, > > from /home/andy/prj/linux- > > topic/include/linux/dmaengine.h:20, > > from /home/andy/prj/linux- > > topic/drivers/dma/dw/core.c:15: > > /home/andy/prj/linux-topic/include/linux/fs.h:2627:74: warning: type > > qualifiers ignored on function return type [-Wignored-qualifiers] > > static inline const char * const kernel_read_file_id_str(enum > > kernel_read_file_id id) > What gcc version are you using? Seems like I need to drop the added > "const" on the return?
$ gcc --version gcc (Debian 5.3.1-14) 5.3.1 20160409
Build was done with $ make W=1
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |