lkml.org 
[lkml]   [2016]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[QUEUED v20160420 06/19] stm class: Do not leak the chrdev in error path
    Date
    Currently, the error path of stm_register_device() forgets to unregister
    the chrdev. Fix this.

    Reported-by: Alan Cox <alan.cox@intel.com>
    Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Reviewed-by: Laurent Fert <laurent.fert@intel.com>
    ---
    drivers/hwtracing/stm/core.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
    index 18f176eac0..e55ed67142 100644
    --- a/drivers/hwtracing/stm/core.c
    +++ b/drivers/hwtracing/stm/core.c
    @@ -688,6 +688,8 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
    return 0;

    err_device:
    + unregister_chrdev(stm->major, stm_data->name);
    +
    /* matches device_initialize() above */
    put_device(&stm->dev);
    err_free:
    --
    2.8.0.rc3
    \
     
     \ /
      Last update: 2016-04-20 13:01    [W:3.636 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site