lkml.org 
[lkml]   [2016]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] regulator: core: Resolve supply earlier
On Tue, Apr 19, 2016 at 11:16:59AM +0100, Jon Hunter wrote:

> So the following seems to work, but only item I am uncertain about
> is if it is ok to move the mutex_lock to after the
> machine_set_constraints()?

We definitely don't need the list to apply constraints to a single
regulator.

> + mutex_lock(&regulator_list_mutex);
> +
> ret = device_register(&rdev->dev);
> if (ret != 0) {
> put_device(&rdev->dev);
> + mutex_unlock(&regulator_list_mutex);
> goto wash;
> }

This is *really* weird. Why would we need the list lock to do a
device_register()?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-04-19 18:01    [W:0.060 / U:43.216 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site