lkml.org 
[lkml]   [2016]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small
From
Date
On 19/04/16 14:46, Masahiro Yamada wrote:
> Hi Adrian,
>
>
> 2016-04-19 20:32 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
>> On 14/04/16 05:29, Masahiro Yamada wrote:
>>> This code checks the resource size and displays an error message if
>>> it is too small, but still moves forward. Let is fail in that case.
>>
>> is -> it
>>
>> How do you know there aren't drivers that actually have a smaller size?
>
> No, I do not know.
>
> This is an error message, so I think it should fail in that case.
>
>
> Maybe, can we drop this check completely?

Yes, I think so.

\
 
 \ /
  Last update: 2016-04-19 15:41    [W:0.038 / U:5.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site