lkml.org 
[lkml]   [2016]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote:
> [...]
>> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
>> .upper_offset = 0x80,
>> };
>>
>> +static struct tegra_gpio_soc_config tegra210_gpio_config = {
>> + .bank_stride = 0x100,
>> + .upper_offset = 0x80,
>> + .debounce_supported = true,
>> +};
>> +
>> static const struct of_device_id tegra_gpio_of_match[] = {
>> + { .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config },
>> { .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
>> { .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
>> { },
> I think I'd split this hunk off into a separate patch. Oh, and perhaps
> follow up with a patch that makes the SoC configuration data const?
>

OK, then I will do that on follow-on patch:
- Get rid of all global variables.
- Convert the soc config to the constant.


\
 
 \ /
  Last update: 2016-04-19 15:21    [W:0.075 / U:2.740 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site