lkml.org 
[lkml]   [2016]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small
From
Date
On 14/04/16 05:29, Masahiro Yamada wrote:
> This code checks the resource size and displays an error message if
> it is too small, but still moves forward. Let is fail in that case.

is -> it

How do you know there aren't drivers that actually have a smaller size?

One that might not is sdhci-dove which appears to sidestep some registers in
sdhci_dove_readw().


>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/mmc/host/sdhci-pltfm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index 072bb27..7d12203 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -127,8 +127,11 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
> goto err;
> }
>
> - if (resource_size(iomem) < 0x100)
> + if (resource_size(iomem) < 0x100) {
> dev_err(&pdev->dev, "Invalid iomem size!\n");
> + ret = -EINVAL;
> + goto err;
> + }
>
> host = sdhci_alloc_host(&pdev->dev,
> sizeof(struct sdhci_pltfm_host) + priv_size);
>

\
 
 \ /
  Last update: 2016-04-19 13:41    [W:0.064 / U:22.928 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site