Messages in this thread | | | Subject | Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate | From | Akshay Adiga <> | Date | Tue, 19 Apr 2016 15:25:40 +0530 |
| |
Hi Viresh,
On 04/18/2016 03:48 PM, Viresh Kumar wrote: > On 15-04-16, 11:58, Akshay Adiga wrote: >> static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb, >> - unsigned long action, void *unused) >> + unsigned long action, void *unused) > Unrelated change.. better don't add such changes..
Posting out v3 with out this unrelated change.
>> { >> int cpu; >> struct cpufreq_policy cpu_policy; >> @@ -603,15 +843,18 @@ static struct notifier_block powernv_cpufreq_opal_nb = { >> static void powernv_cpufreq_stop_cpu(struct cpufreq_policy *policy) >> { >> struct powernv_smp_call_data freq_data; >> - >> + struct global_pstate_info *gpstates = policy->driver_data; > You removed a blank line here and I feel the code looks better with > that. > >> freq_data.pstate_id = powernv_pstate_info.min; >> + freq_data.gpstate_id = powernv_pstate_info.min; >> smp_call_function_single(policy->cpu, set_pstate, &freq_data, 1); >> + del_timer_sync(&gpstates->timer); >> } >> >> static struct cpufreq_driver powernv_cpufreq_driver = { >> .name = "powernv-cpufreq", >> .flags = CPUFREQ_CONST_LOOPS, >> .init = powernv_cpufreq_cpu_init, >> + .exit = powernv_cpufreq_cpu_exit, >> .verify = cpufreq_generic_frequency_table_verify, >> .target_index = powernv_cpufreq_target_index, >> .get = powernv_cpufreq_get, > None of the above comments are mandatory for you to fix.. > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Thanks for Ack :)
| |