lkml.org 
[lkml]   [2016]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework
    On Mon, Apr 18, 2016 at 01:31:09PM +0800, Baolin Wang wrote:
    >
    > We've tried to do this in dm-crypt, but it failed.
    > The dm-crypt maintainer explained to me that I should optimize the
    > driver, not add strange hw-dependent crypto modes to dm-crypt, this is
    > not the first crypto accelerator that is just not suited for this kind
    > of use.
    > He thought if it can process batch of chunks of data each with own IV,
    > then it can work with dm-crypt, but he thought such optimized code
    > should be inside crypto API, not in dmcrypt.

    That's a completely bogus argument. The user always has more
    information available than the underlying API. So it is totally
    stupid to have the API try to extract information that the user
    could have provided in the first place.

    I'm not taking this patch-set.

    Cheers,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

    \
     
     \ /
      Last update: 2016-04-18 08:01    [W:5.407 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site