Messages in this thread | | | Date | Mon, 18 Apr 2016 17:54:09 +0800 | From | Mark yao <> | Subject | Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config |
| |
On 2016年04月18日 17:25, John Keeping wrote: >> >We need to take care of the vop status when use >> >rockchip_drm_crtc_mode_config, if vop is disabled, >> >the function would failed, that is terrible. >> > >> >Save connector type and output mode on drm_display_mode->private_flags >> >at encoder mode_fixup, then we can configure the type and mode safely >> >on crtc mode_set. > Since Rockchip is atomic, shouldn't this be using atomic_check hooks and > a subclassed crtc_state structure? >
Right, Good idea.
Thanks.
-- Mark Yao
| |