Messages in this thread | | | Date | Mon, 18 Apr 2016 09:15:13 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH] thermal: tegra: mark PM functions __maybe_unused |
| |
On Sat, Apr 16, 2016 at 10:19:33PM +0200, Arnd Bergmann wrote: > After the PM support has been added to this driver, we get > a harmless warning when that support is disabled at compile > time: > > drivers/thermal/tegra/soctherm.c:641:12: error: 'soctherm_resume' defined but not used [-Werror=unused-function] > static int soctherm_resume(struct device *dev) > > This marks the two PM functions as __maybe_unused to shut up > the warning. This is preferred over adding an #ifdef around > them, as it is harder to get wrong, and provides better > compile-time coverage. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: a134b4143b65 ("thermal: tegra: add PM support") > --- > drivers/thermal/tegra/soctherm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
The need for this should go away when Jon's generic power domain series gets merged (hopefully very soon now) and enabled on 32-bit ARM. In the meantime:
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |