lkml.org 
[lkml]   [2016]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey
From
On Fri, Apr 15, 2016 at 11:59 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> From: Stephen Boyd <sboyd@codeaurora.org>
> Subject: [PATCH] Input: pmic8xxx-pwrkey: Fix algorithm for converting trigger
> delay
>
> The trigger delay algorithm that converts from microseconds to
> the register value looks incorrect. According to most of the PMIC
> documentation, the equation is
>
> delay (Seconds) = (1 / 1024) * 2 ^ (x + 4)
>
> except for one case where the documentation looks to have a
> formatting issue and the equation looks like
>
> delay (Seconds) = (1 / 1024) * 2 x + 4
>
> Most likely this driver was written with the improper
> documentation to begin with. According to the downstream sources
> the valid delays are from 2 seconds to 1/64 second, and the
> latter equation just doesn't make sense for that. Let's fix the
> algorithm and the range check to match the documentation and the
> downstream sources.
>
> Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: John Stultz <john.stultz@linaro.org>
> Fixes: 92d57a73e410 ("input: Add support for Qualcomm PMIC8XXX power key")
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

This works great for me, and lets me zap the pwrkey node in my dts.

Tested-by: John Stultz <john.stultz@linaro.org>

I'll also send an updated variant of my patch that only removes the gpio key.

thanks!
-john

\
 
 \ /
  Last update: 2016-04-16 00:21    [W:6.525 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site