lkml.org 
[lkml]   [2016]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 5/5] dax: handle media errors in dax_do_io
    From
    On Fri, Apr 15, 2016 at 11:06 AM, Jeff Moyer <jmoyer@redhat.com> wrote:
    > Dan Williams <dan.j.williams@intel.com> writes:
    >
    >>>> There's a lot of special casing here, so you might consider adding
    >>>> comments.
    >>>
    >>> Correct - maybe we should reconsider wrapper-izing this? :)
    >>
    >> Another option is just to skip dax_do_io() and this special casing
    >> fallback entirely if errors are present. I.e. only attempt dax_do_io
    >> when: IS_DAX() && gendisk->bb && bb->count == 0.
    >
    > So, if there's an error anywhere on the device, penalize all I/O (not
    > just writes, and not just on sectors that are bad)? I'm not sure that's
    > a great plan, either.
    >

    If errors are rare how much are we actually losing in practice?
    Moreover, we're going to do the full badblocks lookup anyway when we
    call ->direct_access(). If we had that information earlier we can
    avoid this fallback dance.

    \
     
     \ /
      Last update: 2016-04-15 20:41    [W:4.044 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site