Messages in this thread | | | Date | Thu, 14 Apr 2016 07:45:47 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header |
| |
On Wed, Apr 13, 2016 at 06:39:13PM +0100, Srinivas Kandagatla wrote: > This patch adds dummy function for regmap_can_raw_write() in the header > file, so that the code can be atleast compiled without regmap enabled. > This kind of setup is mostly tested using randomconfig or zero > day-testing.
I'm not convinced that this isn't flagging real problems - it's hard to see how code can safely and sensibly be written which would use this without a dependency on regmap (and given that and the fact that we have no external users we should probably make it internal to the API). [unhandled content-type:application/pgp-signature] | |