Messages in this thread | | | Date | Thu, 14 Apr 2016 11:24:07 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver |
| |
On Wed, Apr 13, 2016 at 02:31:25PM -0500, Timur Tabi wrote: > kbuild test robot wrote: > > > > drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up': > >>>>>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large integer implicitly truncated to unsigned type [-Woverflow] > > writel(~DIS_INT, adpt->base + EMAC_INT_STATUS); > > This doesn't happen on arm64, and I don't know how to fix it. DIS_INT is > defined as:
Probably depends on the compiler version. BTW, clang seems to throw errors for this type of thing.
> > #define DIS_INT BIT(31) > > It seems silly to add a typecast to DIS_INT.
BIT() should use 1U instead of 1.
Rob
| |