lkml.org 
[lkml]   [2016]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 1/3] mmc: pwrseq_simple: add to_pwrseq_simple() macro
    Date
    This patch adds to_pwrseq_simple() macro to make the code more readable.

    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    ---
    drivers/mmc/core/pwrseq_simple.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c
    index bc173e1..f94271b 100644
    --- a/drivers/mmc/core/pwrseq_simple.c
    +++ b/drivers/mmc/core/pwrseq_simple.c
    @@ -25,6 +25,8 @@ struct mmc_pwrseq_simple {
    struct gpio_descs *reset_gpios;
    };

    +#define to_pwrseq_simple(p) container_of(p, struct mmc_pwrseq_simple, pwrseq)
    +
    static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq,
    int value)
    {
    @@ -44,8 +46,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq,

    static void mmc_pwrseq_simple_pre_power_on(struct mmc_host *host)
    {
    - struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
    - struct mmc_pwrseq_simple, pwrseq);
    + struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(host->pwrseq);

    if (!IS_ERR(pwrseq->ext_clk) && !pwrseq->clk_enabled) {
    clk_prepare_enable(pwrseq->ext_clk);
    @@ -57,16 +58,14 @@ static void mmc_pwrseq_simple_pre_power_on(struct mmc_host *host)

    static void mmc_pwrseq_simple_post_power_on(struct mmc_host *host)
    {
    - struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
    - struct mmc_pwrseq_simple, pwrseq);
    + struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(host->pwrseq);

    mmc_pwrseq_simple_set_gpios_value(pwrseq, 0);
    }

    static void mmc_pwrseq_simple_power_off(struct mmc_host *host)
    {
    - struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
    - struct mmc_pwrseq_simple, pwrseq);
    + struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(host->pwrseq);

    mmc_pwrseq_simple_set_gpios_value(pwrseq, 1);

    @@ -78,8 +77,7 @@ static void mmc_pwrseq_simple_power_off(struct mmc_host *host)

    static void mmc_pwrseq_simple_free(struct mmc_host *host)
    {
    - struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq,
    - struct mmc_pwrseq_simple, pwrseq);
    + struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(host->pwrseq);

    if (!IS_ERR(pwrseq->reset_gpios))
    gpiod_put_array(pwrseq->reset_gpios);
    --
    2.5.0
    \
     
     \ /
      Last update: 2016-04-14 15:21    [W:2.988 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site