Messages in this thread | | | Date | Wed, 13 Apr 2016 11:19:33 -0600 | From | Ross Zwisler <> | Subject | Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32 |
| |
On Tue, Apr 12, 2016 at 10:24:25PM -0700, Dan Williams wrote: > On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani <toshi.kani@hpe.com> wrote: > > After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe() > > for memcpy_from_pmem()")', probing a PMEM device hits the BUG() > > error below on X86_32 kernel. > > > > kernel BUG at include/linux/pmem.h:48! > > > > memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is > > unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on > > X86_32. > > > > Fix the BUG() error by adding default_memcpy_from_pmem(). > > > > Signed-off-by: Toshi Kani <toshi.kani@hpe.com> > > Cc: Dan Williams <dan.j.williams@intel.com> > > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > > Whoops, I'll add a 32-bit boot test to my release criteria. Thanks Toshi!
Yep, this patch looks correct to me.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
| |