lkml.org 
[lkml]   [2016]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PART1 RFC v4 08/11] svm: Add VMEXIT handlers for AVIC
2016-04-13 00:29+0200, Paolo Bonzini:
> On 12/04/2016 18:22, Radim Krčmář wrote:
>>> > + if (apic_id > 4 || cluster_id >= 0xf)
>>> > + return NULL;
>>> > + index = (cluster_id << 2) + apic_id;
>> ffs(apic_id), because 'apic_id' must be compacted into 2 bits.
>
> ffs(apic_id)-1 actually.

Yes, thanks.

(And I missed that the confusion begins by passing "ffs(dlid) - 1" as
mda to avic_handle_ldr_write, because the rest cannot work after that.)

\
 
 \ /
  Last update: 2016-04-13 15:01    [W:0.080 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site