lkml.org 
[lkml]   [2016]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq.
From
Date
On Mon, 2016-04-11 at 09:50 +0100, Lee Jones wrote:
> On Fri, 08 Apr 2016, Henry Chen wrote:
>
> > If get the -EPROBE_DEFER from platform_get_irq, it should return back directly.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > drivers/mfd/mt6397-core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > index 15050cb..b9b1e28 100644
> > --- a/drivers/mfd/mt6397-core.c
> > +++ b/drivers/mfd/mt6397-core.c
> > @@ -271,6 +271,8 @@ static int mt6397_probe(struct platform_device *pdev)
> > }
> >
> > pmic->irq = platform_get_irq(pdev, 0);
> > + if (pmic->irq == -EPROBE_DEFER)
> > + return -EPROBE_DEFER;
>
> if (ret < 0)
> return ret;
>
> ... is more common, as it covers more bases, etc.

Okay, the interrupt should be a required properties, if get failed just
return back.

I will also change the binding doc.

Thanks.

>
> > switch (id & 0xff) {
> > case MT6323_CID_CODE:
>


\
 
 \ /
  Last update: 2016-04-13 08:01    [W:0.043 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site