lkml.org 
[lkml]   [2016]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: "
From
Date
On 2016/4/11 23:32, Julien Grall wrote:
> Currently, most of the pr_* messages in the GICv3 driver don't have a
> prefix. Add one to make clear where the messages come from.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
> Changes in v6:
> - Patch added
> ---
> drivers/irqchip/irq-gic-v3.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 5b7d3c2..6dc6f03 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -15,6 +15,8 @@
> * along with this program. If not, see <http://www.gnu.org/licenses/>.
> */
>
> +#define pr_fmt(fmt) "GICv3: " fmt

I don't think this patch is needed, as GICv3 and GICv2 will
not be probed at the same time, did I miss something?

Further more, there are prefixes in pr_fmt in this
patch using GIC:, with your patch added, it will print:

GIV3: GIC: .....

which is not a good idea.

Thanks
Hanjun

\
 
 \ /
  Last update: 2016-04-13 12:21    [W:0.144 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site