Messages in this thread | | | Date | Mon, 11 Apr 2016 16:49:02 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 1/5] regulator: core: Resolve supply earlier |
| |
On Mon, Apr 11, 2016 at 03:32:39PM +0100, Mark Brown wrote: > On Mon, Apr 11, 2016 at 04:07:30PM +0200, Thierry Reding wrote: > > > Okay, so how do we proceed here? Currently Jetson TK1 is broken because > > bypass mode requires the parent to be available at probe time due to new > > code that's now doing a regulator_get_voltage() during the initial call > > to set_machine_constraints(). > > I think we should be doing what I'd expected this series to do and > looking up the supply as and when we need it when applying constraints. > That will only affect systems where there is a practical issue which > should minimise the impact.
I must have misinterpreted our discussion on IRC, then, because I thought this was exactly what you had been expecting. =\ I'll go look for my earlier patch and repost.
> Long term we want a bigger refactoring but > I think we need to sort out what's going on with probe ordering in > general before we do that, that's part of the problem here - people > really aren't happy with deferral and for good reason.
What happened to correctness first? I thought we had at some point all agreed that even if deferred probe wasn't perfect it would at least give us correct results. And if all the code in place to properly establish the dependencies we could rid ourselves of all the downsides at once if ever we came up with a better alternative.
Thierry [unhandled content-type:application/pgp-signature] | |