Messages in this thread | | | Date | Mon, 11 Apr 2016 10:31:38 +0100 | From | Lee Jones <> | Subject | Re: [PATCH V2 13/20] mfd: rn5t618: Use devm_mfd_add_devices() for mfd_device registration |
| |
Applied, thanks.
On Fri, 08 Apr 2016, Laxman Dewangan wrote:
> Use devm_mfd_add_devices() for MFD devices registration and remove > the call of mfd_remove_devices() from .remove callback to remove > MFD child-devices. This is done by managed device framework. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Beniamino Galvani <b.galvani@gmail.com> > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > > drivers/mfd/rn5t618.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c > index 6668571..0ad51d7 100644 > --- a/drivers/mfd/rn5t618.c > +++ b/drivers/mfd/rn5t618.c > @@ -78,8 +78,8 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c, > return ret; > } > > - ret = mfd_add_devices(&i2c->dev, -1, rn5t618_cells, > - ARRAY_SIZE(rn5t618_cells), NULL, 0, NULL); > + ret = devm_mfd_add_devices(&i2c->dev, -1, rn5t618_cells, > + ARRAY_SIZE(rn5t618_cells), NULL, 0, NULL); > if (ret) { > dev_err(&i2c->dev, "failed to add sub-devices: %d\n", ret); > return ret; > @@ -102,7 +102,6 @@ static int rn5t618_i2c_remove(struct i2c_client *i2c) > pm_power_off = NULL; > } > > - mfd_remove_devices(&i2c->dev); > return 0; > } >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |