lkml.org 
[lkml]   [2016]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.5 096/238] staging: android: ion_test: fix check of platform_device_register_simple() error code
    Date
    4.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vladimir Zapolskiy <vz@mleia.com>

    commit ccbc2a9e7878ff09bcaed4893c2a2d3adbb797e2 upstream.

    On error platform_device_register_simple() returns ERR_PTR() value,
    check for NULL always fails. The change corrects the check itself and
    propagates the returned error upwards.

    Fixes: 81fb0b901397 ("staging: android: ion_test: unregister the platform device")
    Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/android/ion/ion_test.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/staging/android/ion/ion_test.c
    +++ b/drivers/staging/android/ion/ion_test.c
    @@ -285,8 +285,8 @@ static int __init ion_test_init(void)
    {
    ion_test_pdev = platform_device_register_simple("ion-test",
    -1, NULL, 0);
    - if (!ion_test_pdev)
    - return -ENODEV;
    + if (IS_ERR(ion_test_pdev))
    + return PTR_ERR(ion_test_pdev);

    return platform_driver_probe(&ion_test_platform_driver, ion_test_probe);
    }

    \
     
     \ /
      Last update: 2016-04-10 21:01    [W:6.053 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site