lkml.org 
[lkml]   [2016]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Add a turbo mode sysctl
On Fri, 1 Apr 2016, Andy Lutomirski wrote:
> +static void update_local_turbo_mode(void *dummy)
> +{
> + unsigned long cr0 = read_cr0();
> +
> + /*
> + * KVM doesn't properly handle CD.
> + *
> + * XXX: this may interact poorly with CPU hotplug.

Please cc these crazy folks who cleanup the hotplug mess so they can put it on
their todo list.

> + */
> +
> + if (turbo_mode)
> + write_cr0(cr0 & ~X86_CR0_CD);
> + else
> + write_cr0(cr0 | X86_CR0_CD);

I think proper turbo mode disable requires ~(X86_CR0_CD | X86_CR0_NW)

> +static void update_turbo_mode(void)
> +{
> + on_each_cpu(update_local_turbo_mode, NULL, 1);
> +
> + if (!turbo_mode)
> + wbinvd();

You really want to do wbinvd() on each cpu to make sure that each cpu gets out
of that turbo thing.

Thanks,

tglx

\
 
 \ /
  Last update: 2016-04-01 18:41    [W:0.064 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site