lkml.org 
[lkml]   [2016]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit()
On Fri, 1 Apr 2016, Rusty Russell wrote:

> >> __module_put_and_exit() is makred noreturn in module.h declaration, but is
> >> lacking the attribute in the definition, which makes some tools (such as
> >> sparse) unhappy. Amend the definition with the attribute as well (and
> >> reformat the declaration so that it uses more common format).
> >>
> >> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >> ---
> >>
> >> v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested
> >> by Rusty
> >
> > Rusty, friendly ping on this one.
> >
> > Thanks!
>
> Oops, I applied it, and in testing noted that lguest had broken and
> ended up getting distracted by that. I've acked it now (it will
> probably wait until next merge window).

Sorry, non comprende :) Could you please elaborate? Are you saying this
patch broke lguest? What is the breakage about?

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2016-04-01 09:01    [W:0.046 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site