lkml.org 
[lkml]   [2016]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched/deadline: No need to check NULL later_mask
From
Date
On 2016/04/01 at 19:29, Peter Zijlstra wrote:
> On Fri, Apr 01, 2016 at 07:13:18PM +0800, Xunlei Pang wrote:
>> Unlike rt tasks, we (should) have no deadline tasks in
>> booting phase before the mask is allocated, so we can
>> safely remove the check.
> Why? And have the kernel explode once it grows an early deadline task?
>
> Is there _any_ benefit to this?

This is a performance-critical path, it'd be better to avoid such a check.

I think in the early boot stage before sched_init_smp(), it's weird to
use a deadline task, relying on rt tasks should be enough for us.

Please ignore it if you don't think so :-)

Regards,
Xunlei

\
 
 \ /
  Last update: 2016-04-01 15:01    [W:6.563 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site