lkml.org 
[lkml]   [2016]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized
From
On Thu, Mar 31, 2016 at 6:21 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Tue, Mar 29, 2016 at 11:15:49AM -0700, Guenter Roeck wrote:
>> The sa1100 gpio driver was initialized from interrupt initialization code,
>> which is earlier than the gpio subsystem is initialized. Since commit
>> ff2b13592299 ("gpio: make the gpiochip a real device"), this is fatal
>> and causes the system to crash.
>>
>> The sa1100 gpio driver must be initialized prior to arch_initcall, since
>> its gpio pins are used in arch_initcall code, but after the gpio subsystem
>> is initialized (core_initcall). Initialize it with postcore_initcall.
>>
>> Fixes: ff2b13592299 ("gpio: make the gpiochip a real device")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Please ignore/drop this patch - a better (cleaner) fix is in the works
> for gpiolib.

This delivers though. I tested it on my also regressing iPAQ.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2016-04-01 10:41    [W:0.314 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site