lkml.org 
[lkml]   [2016]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC 0/7] eliminate snprintf with overlapping src and dst
From
On Tue, Mar 8, 2016 at 10:40 PM, Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
> Doing snprintf(buf, len, "%s...", buf, ...) for appending to a buffer
> currently works, but it is somewhat fragile, and any other overlap
> between source and destination buffers would be a definite bug. This
> is an attempt at eliminating the relatively few occurences of this
> pattern in the kernel.
>
> I could use another set of eyes on all of these. The drm/amdkfd patch
> is unfortunately rather large, but I couldn't find a better way to do
> this.

Would we use seq_buf API instead in that case?

>
> Rasmus Villemoes (7):
> drm/amdkfd: avoid fragile and inefficient snprintf use
> Input: joystick - avoid fragile snprintf use
> leds: avoid fragile sprintf use
> drivers/media/pci/zoran: avoid fragile snprintf use
> wlcore: avoid fragile snprintf use
> [media] ati_remote: avoid fragile snprintf use
> USB: usbatm: avoid fragile and inefficient snprintf use



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2016-03-09 08:21    [W:1.818 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site