lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 169/196] net: Copy inner L3 and L4 headers as unaligned on GRE TEB
    Date
    3.19.8-ckt16 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Alexander Duyck <aduyck@mirantis.com>

    [ Upstream commit 78565208d73ca9b654fb9a6b142214d52eeedfd1 ]

    This patch corrects the unaligned accesses seen on GRE TEB tunnels when
    generating hash keys. Specifically what this patch does is make it so that
    we force the use of skb_copy_bits when the GRE inner headers will be
    unaligned due to NET_IP_ALIGNED being a non-zero value.

    Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
    Acked-by: Tom Herbert <tom@herbertland.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    net/core/flow_dissector.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
    index e36bd03..bb9e175 100644
    --- a/net/core/flow_dissector.c
    +++ b/net/core/flow_dissector.c
    @@ -219,6 +219,13 @@ ipv6:
    return false;
    proto = eth->h_proto;
    nhoff += sizeof(*eth);
    +
    + /* Cap headers that we access via pointers at the
    + * end of the Ethernet header as our maximum alignment
    + * at that point is only 2 bytes.
    + */
    + if (NET_IP_ALIGN)
    + hlen = nhoff;
    }
    goto again;
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-09 02:21    [W:4.246 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site