lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 193/196] s390/stacktrace: fix address ranges for asynchronous and panic stack
    Date
    3.19.8-ckt16 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Heiko Carstens <heiko.carstens@de.ibm.com>

    commit 9900c48c46d8bcf497972024c5fe366e6d9771f3 upstream.

    git commit dc7ee00d4771 ("s390: lowcore stack pointer offsets")
    introduced a regression in regard to save_stack_trace(). The stack
    pointer for the asynchronous and the panic stack in the lowcore now
    have an additional offset applied to them. This offset needs to be
    taken into account in the calculation for the low and high address for
    the stacks.

    This bug was already partially fixed with 9cc5c206d9b4
    ("s390/dumpstack: fix address ranges for asynchronous and panic
    stack"). This patch fixes it also for the stacktrace code.

    Fixes: dc7ee00d4771 ("s390: lowcore stack pointer offsets")
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Tested-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    arch/s390/kernel/stacktrace.c | 11 ++++++-----
    1 file changed, 6 insertions(+), 5 deletions(-)

    diff --git a/arch/s390/kernel/stacktrace.c b/arch/s390/kernel/stacktrace.c
    index 1785cd8..8be2c35 100644
    --- a/arch/s390/kernel/stacktrace.c
    +++ b/arch/s390/kernel/stacktrace.c
    @@ -63,17 +63,18 @@ static unsigned long save_context_stack(struct stack_trace *trace,
    void save_stack_trace(struct stack_trace *trace)
    {
    register unsigned long sp asm ("15");
    - unsigned long orig_sp, new_sp;
    + unsigned long orig_sp, new_sp, frame_size;

    + frame_size = STACK_FRAME_OVERHEAD + sizeof(struct pt_regs);
    orig_sp = sp & PSW_ADDR_INSN;
    new_sp = save_context_stack(trace, orig_sp,
    - S390_lowcore.panic_stack - PAGE_SIZE,
    - S390_lowcore.panic_stack, 1);
    + S390_lowcore.panic_stack + frame_size - PAGE_SIZE,
    + S390_lowcore.panic_stack + frame_size, 1);
    if (new_sp != orig_sp)
    return;
    new_sp = save_context_stack(trace, new_sp,
    - S390_lowcore.async_stack - ASYNC_SIZE,
    - S390_lowcore.async_stack, 1);
    + S390_lowcore.async_stack + frame_size - ASYNC_SIZE,
    + S390_lowcore.async_stack + frame_size, 1);
    if (new_sp != orig_sp)
    return;
    save_context_stack(trace, new_sp,
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-09 02:21    [W:4.145 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site