lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 004/196] iw_cxgb3: Fix incorrectly returning error on success
    Date
    3.19.8-ckt16 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Hariprasad S <hariprasad@chelsio.com>

    commit 67f1aee6f45059fd6b0f5b0ecb2c97ad0451f6b3 upstream.

    The cxgb3_*_send() functions return NET_XMIT_ values, which are
    positive integers values. So don't treat positive return values
    as an error.

    Signed-off-by: Steve Wise <swise@opengridcomputing.com>
    Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/infiniband/hw/cxgb3/iwch_cm.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
    index cb78b1e..f504ba7 100644
    --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
    +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
    @@ -149,7 +149,7 @@ static int iwch_l2t_send(struct t3cdev *tdev, struct sk_buff *skb, struct l2t_en
    error = l2t_send(tdev, skb, l2e);
    if (error < 0)
    kfree_skb(skb);
    - return error;
    + return error < 0 ? error : 0;
    }

    int iwch_cxgb3_ofld_send(struct t3cdev *tdev, struct sk_buff *skb)
    @@ -165,7 +165,7 @@ int iwch_cxgb3_ofld_send(struct t3cdev *tdev, struct sk_buff *skb)
    error = cxgb3_ofld_send(tdev, skb);
    if (error < 0)
    kfree_skb(skb);
    - return error;
    + return error < 0 ? error : 0;
    }

    static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff *skb)
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-09 03:01    [W:4.329 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site