| From | Kamal Mostafa <> | Subject | [PATCH 3.19.y-ckt 006/196] ALSA: usb-audio: avoid freeing umidi object twice | Date | Tue, 8 Mar 2016 16:27:44 -0800 |
| |
3.19.8-ckt16 -stable review patch. If anyone has any objections, please let me know.
---8<------------------------------------------------------------
From: Andrey Konovalov <andreyknvl@gmail.com>
commit 07d86ca93db7e5cdf4743564d98292042ec21af7 upstream.
The 'umidi' object will be free'd on the error path by snd_usbmidi_free() when tearing down the rawmidi interface. So we shouldn't try to free it in snd_usbmidi_create() after having registered the rawmidi interface.
Found by KASAN.
Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com> Acked-by: Clemens Ladisch <clemens@ladisch.de> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Kamal Mostafa <kamal@canonical.com> --- sound/usb/midi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/usb/midi.c b/sound/usb/midi.c index a074f1c..7064698 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -2452,7 +2452,6 @@ int snd_usbmidi_create(struct snd_card *card, else err = snd_usbmidi_create_endpoints(umidi, endpoints); if (err < 0) { - snd_usbmidi_free(umidi); return err; } -- 2.7.0
|