lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 109/196] xen/pciback: Save the number of MSI-X entries to be copied later.
    Date
    3.19.8-ckt16 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

    commit d159457b84395927b5a52adb72f748dd089ad5e5 upstream.

    Commit 8135cf8b092723dbfcc611fe6fdcb3a36c9951c5 (xen/pciback: Save
    xen_pci_op commands before processing it) broke enabling MSI-X because
    it would never copy the resulting vectors into the response. The
    number of vectors requested was being overwritten by the return value
    (typically zero for success).

    Save the number of vectors before processing the op, so the correct
    number of vectors are copied afterwards.

    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
    Signed-off-by: David Vrabel <david.vrabel@citrix.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/xen/xen-pciback/pciback_ops.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
    index 1078e8d..fb02214 100644
    --- a/drivers/xen/xen-pciback/pciback_ops.c
    +++ b/drivers/xen/xen-pciback/pciback_ops.c
    @@ -333,6 +333,9 @@ void xen_pcibk_do_op(struct work_struct *data)
    struct xen_pcibk_dev_data *dev_data = NULL;
    struct xen_pci_op *op = &pdev->op;
    int test_intx = 0;
    +#ifdef CONFIG_PCI_MSI
    + unsigned int nr = 0;
    +#endif

    *op = pdev->sh_info->op;
    barrier();
    @@ -361,6 +364,7 @@ void xen_pcibk_do_op(struct work_struct *data)
    op->err = xen_pcibk_disable_msi(pdev, dev, op);
    break;
    case XEN_PCI_OP_enable_msix:
    + nr = op->value;
    op->err = xen_pcibk_enable_msix(pdev, dev, op);
    break;
    case XEN_PCI_OP_disable_msix:
    @@ -383,7 +387,7 @@ void xen_pcibk_do_op(struct work_struct *data)
    if (op->cmd == XEN_PCI_OP_enable_msix && op->err == 0) {
    unsigned int i;

    - for (i = 0; i < op->value; i++)
    + for (i = 0; i < nr; i++)
    pdev->sh_info->op.msix_entries[i].vector =
    op->msix_entries[i].vector;
    }
    --
    2.7.0
    \
     
     \ /
      Last update: 2016-03-09 02:41    [W:3.526 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site