Messages in this thread | | | From | 河合英宏 / KAWAI,HIDEHIRO <> | Subject | RE: [v3 PATCH 1/3] panic: Change nmi_panic from macro to function | Date | Mon, 7 Mar 2016 10:53:51 +0000 |
| |
> From: Borislav Petkov [mailto:bp@alien8.de] > On Thu, Mar 03, 2016 at 07:57:44PM +0900, Hidehiro Kawai wrote: > > Change nmi_panic() macro to a normal function for the portability. > > portability?
I wanted to say encapsulating things into a function makes modules only have to know about the function. Modules don't need to know all things in the macro. But I thought again, and `portability' was not appropriate.
However, this patch set has been queued into -mm now. So I'll leave this if not necessary.
Regards, Hidehiro Kawai
> > Also, export it for modules. > > > > Changes since v2: > > - Make nmi_panic receive a single string instead of printf style args > > > > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: Borislav Petkov <bp@suse.de> > > Cc: Michal Nazarewicz <mina86@mina86.com> > > Cc: Michal Hocko <mhocko@suse.com> > > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> > > Cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > > Cc: Javi Merino <javi.merino@arm.com> > > Cc: Gobinda Charan Maji <gobinda.cemk07@gmail.com> > > Cc: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Vitaly Kuznetsov <vkuznets@redhat.com> > > Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> > > Cc: Tejun Heo <tj@kernel.org> > > --- > > include/linux/kernel.h | 21 +-------------------- > > kernel/panic.c | 20 ++++++++++++++++++++ > > 2 files changed, 21 insertions(+), 20 deletions(-) > > Acked-by: Borislav Petkov <bp@suse.de> > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply.
| |