Messages in this thread Patch in this message | | | Date | Sat, 5 Mar 2016 00:19:54 -0800 | From | "tip-bot for Steven Rostedt (Red Hat)" <> | Subject | [tip:perf/core] tools lib traceevent: Fix output of %llu for 64 bit values read on 32 bit machines |
| |
Commit-ID: a66673a07e260807f570db8f08a9c1207932c665 Gitweb: http://git.kernel.org/tip/a66673a07e260807f570db8f08a9c1207932c665 Author: Steven Rostedt (Red Hat) <rostedt@goodmis.org> AuthorDate: Tue, 9 Feb 2016 15:40:17 -0500 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 3 Mar 2016 11:10:38 -0300
tools lib traceevent: Fix output of %llu for 64 bit values read on 32 bit machines
When a long value is read on 32 bit machines for 64 bit output, the parsing needs to change "%lu" into "%llu", as the value is read natively.
Unfortunately, if "%llu" is already there, the code will add another "l" to it and fail to parse it properly.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Cc: Andrew Morton <akpm@linux-foundation.org> Link: http://lkml.kernel.org/r/20160209204237.337024613@goodmis.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/lib/traceevent/event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index fb790aa..865dea5 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -4978,7 +4978,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event break; } } - if (pevent->long_size == 8 && ls && + if (pevent->long_size == 8 && ls == 1 && sizeof(long) != 8) { char *p;
| |