lkml.org 
[lkml]   [2016]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parport: register driver later
On Fri, Mar 04, 2016 at 04:20:59PM +0530, Sudip Mukherjee wrote:
> If the parport bus is not yet registered and any device using parallel
> port tries to register with the bus we get a stackdump with a message
> of Kernel bug.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: <stable@vger.kernel.org> # 4.2+
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>
> We should actually have some deferred probe here. But considering that
> you will be closing your trees soon so a quick fix to solve the problem
> for now. We will revisit this when we remove the old api (hopefully v4.7).
>
> drivers/parport/share.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> index 3308427..176b2b6 100644
> --- a/drivers/parport/share.c
> +++ b/drivers/parport/share.c
> @@ -273,6 +273,9 @@ int __parport_register_driver(struct parport_driver *drv, struct module *owner,
> /* using device model */
> int ret;
>
> + if (!parport_bus_type.p)
> + return -EAGAIN;

I really don't like it when busses poke into the driver-core
internal-only structures like this. Why can't you have your own "have
been registered" flag instead if you really need it? Don't rely on the
driver core here to be doing this always this way, perhaps p could be
NULL and it only is created later on somehow?

I need to rename 'p' to "do_not_touch_you_have_been_warned" or something
else...

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-03-05 22:01    [W:0.074 / U:3.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site