lkml.org 
[lkml]   [2016]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/5] usb: gadget: f_midi: refactor state machine
    From
    Date
    Felipe Ferreri Tonello wrote:
    > On 03/03/16 11:38, Clemens Ladisch wrote:
    >> But in what way was the old state machine not "proper"?
    >
    > Because it didn't reflect all the correct and possible MIDI states

    The whole point of the one-byte real-time messages is that they do not
    affect the parsing of the surrounding MIDI stream. So not making them
    part of the state machine is the proper way of handling them. (Also
    see the flowchart in appendix A of the spec.)

    > This patch doesn't change any functionality. But the important thing
    > here is that it improves the driver maintainability [...]

    Then I won't get in the way of this driver's maintainer.


    Regards,
    Clemens

    \
     
     \ /
      Last update: 2016-03-04 11:01    [W:2.723 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site